Error when saving album settings from the settings tab #102

New Issue

aheathershaw · 2018-09-13T21:06:17+01:00

aheathershaw commented

2018-09-13 21:06:17 +01:00

When you edit an album’s settings within the Settings tab of the album itself, you get an error.

Changing the album through the album’s edit screen works fine.

When you edit an album’s settings within the Settings tab of the album itself, you get an error. Changing the album through the album’s edit screen works fine.

aheathershaw self-assigned this 2018-09-13 21:06:17 +01:00

aheathershaw added the

bug

label 2018-09-13 21:06:17 +01:00

aheathershaw commented

2018-09-13 21:32:24 +01:00

This is due to the validation added in #58, allowing albums with the same name to exist under different parents.

The settings tab does not have the “parent” field that the Edit screen does, so it causes an undefined index trying to access the field’s value.

The validation needs to use the album’s current parent when this field is not present in the data.

This is due to the validation added in #58, allowing albums with the same name to exist under different parents. The settings tab does not have the “parent” field that the Edit screen does, so it causes an undefined index trying to access the field’s value. The validation needs to use the album’s current parent when this field is not present in the data.

aheathershaw added this to the (deleted) milestone 2018-09-14 07:26:56 +01:00

aheathershaw commented

2019-07-15 22:37:34 +01:00

This is also present in Cloud, needs fixing in 2.2.0 and merging across.

aheathershaw modified the milestone from (deleted) to Version 2.2.0-beta.1

2019-07-15 22:37:39 +01:00

aheathershaw added the

wip

label 2019-07-21 08:12:34 +01:00

aheathershaw referenced this issue from a commit

2019-07-21 08:25:48 +01:00

Fixes #102: include the parent album ID in the edit form to work with the validation