aheathershaw/blue-twilight
1
0
Fork 0
Code Issues 32 Pull Requests Releases 15 Wiki Activity

Migrate social network credentials to new services section #152

New Issue
Closed
opened 2020-04-28 22:08:08 +01:00 by aheathershaw · 2 comments
aheathershaw commented 2020-04-28 22:08:08 +01:00
Owner
Copy Link

The Facebook/Twitter/Google app client ID and app secret should be migrated by a data migration from the configuration table into the new "services" table.

The admin screen needs to present a drop-down listing the services applicable to each provider - e.g. the Facebook section should list all services of type "facebook."

When any of the following is hit, if there is no "service" selector for each social provider, the configuration option should be disabled:

  • admin screen
  • login screen
The Facebook/Twitter/Google app client ID and app secret should be migrated by a data migration from the configuration table into the new "services" table. The admin screen needs to present a drop-down listing the services applicable to each provider - e.g. the Facebook section should list all services of type "facebook." When any of the following is hit, if there is no "service" selector for each social provider, the configuration option should be disabled: * admin screen * login screen
aheathershaw added this to the Version 2.2.0-beta.2 milestone 2020-04-28 22:08:08 +01:00
aheathershaw added the
enhancement
 label 2020-04-28 22:08:08 +01:00
aheathershaw self-assigned this 2020-04-28 22:08:08 +01:00
aheathershaw commented 2020-04-29 12:11:21 +01:00
Author
Owner
Copy Link

This will also resolve an issue where a social network can be enabled and used for login/registration even if no app ID/secret has been provided - resulting in a 500 server error.

This will also resolve an issue where a social network can be enabled and used for login/registration even if no app ID/secret has been provided - resulting in a 500 server error.
aheathershaw added the
wip
 label 2020-04-29 15:26:58 +01:00
aheathershaw commented 2020-04-29 22:20:58 +01:00
Author
Owner
Copy Link

Last 2 things left to do for this:

  • Data migration to move the config from the settings table to the services table
  • Add a link to the config screen underneath the services dropdown to the services screen
Last 2 things left to do for this: * [x] Data migration to move the config from the settings table to the services table * [x] Add a link to the config screen underneath the services dropdown to the services screen
aheathershaw removed the
wip
 label 2020-04-30 08:29:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

   
enhancement

   
feature

   
invalid

   
task

   
wip
No Label
bug
enhancement
feature
invalid
task
wip
Milestone
Clear milestone
No items
No Milestone
Version 2.2.0-beta.2
Assignees
Clear assignees
No Assignees
aheathershaw
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: aheathershaw/blue-twilight#152
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?