Album with sub-albums and no photos is shown as empty #54

New Issue

aheathershaw · 2018-07-28T09:52:40+01:00

aheathershaw commented

2018-07-28 09:52:40 +01:00

0 photos is shown in the album description, it should also show the number of sub-albums.
Also, it's treated as empty even if there are sub-albums with photos inside.

Note: sub-albums are displayed correctly, but the main album should show that it's not actually empty.

[LNT00](https://github.com/LNT00): 0 photos is shown in the album description, it should also show the number of sub-albums. Also, it's treated as empty even if there are sub-albums with photos inside. Note: sub-albums are displayed correctly, but the main album should show that it's not actually empty.

aheathershaw added this to the Version 2.1.0 milestone 2018-07-28 09:52:40 +01:00

aheathershaw added the

enhancement

label 2018-07-28 09:52:40 +01:00

aheathershaw commented

2018-07-28 09:53:17 +01:00

As a note whilst working on this: 1 photo is also displayed as "1 photos”

As a note whilst working on this: 1 photo is also displayed as "1 photo**s**”

aheathershaw commented

2018-07-28 09:53:24 +01:00

Also the thumbnail for the parent album should really take into account child albums as well if the parent album has no photos.

aheathershaw commented

2018-07-28 09:53:52 +01:00

@cozmalaurentiu please can you take a look at this link: http://blue-twilight-dev.andys.eu/

You'll see the "Test" album has no photos - however it's thumbnail has been "bought up" from one of the child albums.

It now also says "2 more albums" in the album's footer (which is only visible if there are child albums available.)

When you click onto the album, you no longer see the message that the album is empty if there are child albums available.

@cozmalaurentiu please can you take a look at this link: http://blue-twilight-dev.andys.eu/ You'll see the "Test" album has no photos - however it's thumbnail has been "bought up" from one of the child albums. It now also says "2 more albums" in the album's footer (which is only visible if there are child albums available.) When you click onto the album, you no longer see the message that the album is empty if there are child albums available.

aheathershaw commented

2018-07-28 09:54:21 +01:00

LNT00:

Yes, looks ok. What happens when first album has no photos and there is a photo in the second album?

I created an account there but i cannot create albums. :)

[LNT00](https://github.com/LNT00): Yes, looks ok. What happens when first album has no photos and there is a photo in the second album? I created an account there but i cannot create albums. :)

aheathershaw commented

2018-07-28 09:54:30 +01:00

I've given you permission to create albums on there - that's my development system so don't be alarmed if things go missing from time-to-time ;-)

The "Test" album has no photos, but it contains a child album "Child Test" that does - which is that scenario you've described.

Thumbnails are pulled up from the child albums if the parent doesn't have any photos itself, and the parent album does not display the large "no photos" image and message, but a more subtle one with child albums more visible.

I've given you permission to create albums on there - that's my development system so don't be alarmed if things go missing from time-to-time ;-) The "Test" album has no photos, but it contains a child album "Child Test" that does - which is that scenario you've described. Thumbnails are pulled up from the child albums if the parent doesn't have any photos itself, and the parent album does not display the large "no photos" image and message, but a more subtle one with child albums more visible.

aheathershaw commented

2018-07-28 09:54:36 +01:00

This will be in the 2.1.0-beta.4 release