Album with sub-albums and no photos is shown as empty #54

Chiuso
aperto 2018-07-28 09:52:40 +01:00 da aheathershaw · 7 commenti
Proprietario

LNT00:

0 photos is shown in the album description, it should also show the number of sub-albums.
Also, it's treated as empty even if there are sub-albums with photos inside.

Note: sub-albums are displayed correctly, but the main album should show that it's not actually empty.

[LNT00](https://github.com/LNT00): 0 photos is shown in the album description, it should also show the number of sub-albums. Also, it's treated as empty even if there are sub-albums with photos inside. Note: sub-albums are displayed correctly, but the main album should show that it's not actually empty.
aheathershaw aggiunta alle pietre miliari Version 2.1.0 2018-07-28 09:52:40 +01:00
aheathershaw ha aggiunto l'etichetta
enhancement
2018-07-28 09:52:40 +01:00
Autore
Proprietario

As a note whilst working on this: 1 photo is also displayed as "1 photos

As a note whilst working on this: 1 photo is also displayed as "1 photo**s**”
Autore
Proprietario

Also the thumbnail for the parent album should really take into account child albums as well if the parent album has no photos.

Also the thumbnail for the parent album should really take into account child albums as well if the parent album has no photos.
Autore
Proprietario

@cozmalaurentiu please can you take a look at this link: http://blue-twilight-dev.andys.eu/

You'll see the "Test" album has no photos - however it's thumbnail has been "bought up" from one of the child albums.

It now also says "2 more albums" in the album's footer (which is only visible if there are child albums available.)

When you click onto the album, you no longer see the message that the album is empty if there are child albums available.

@cozmalaurentiu please can you take a look at this link: http://blue-twilight-dev.andys.eu/ You'll see the "Test" album has no photos - however it's thumbnail has been "bought up" from one of the child albums. It now also says "2 more albums" in the album's footer (which is only visible if there are child albums available.) When you click onto the album, you no longer see the message that the album is empty if there are child albums available.
Autore
Proprietario

LNT00:

Yes, looks ok. What happens when first album has no photos and there is a photo in the second album?

I created an account there but i cannot create albums. :)

[LNT00](https://github.com/LNT00): Yes, looks ok. What happens when first album has no photos and there is a photo in the second album? I created an account there but i cannot create albums. :)
Autore
Proprietario

I've given you permission to create albums on there - that's my development system so don't be alarmed if things go missing from time-to-time ;-)

The "Test" album has no photos, but it contains a child album "Child Test" that does - which is that scenario you've described.

Thumbnails are pulled up from the child albums if the parent doesn't have any photos itself, and the parent album does not display the large "no photos" image and message, but a more subtle one with child albums more visible.

I've given you permission to create albums on there - that's my development system so don't be alarmed if things go missing from time-to-time ;-) The "Test" album has no photos, but it contains a child album "Child Test" that does - which is that scenario you've described. Thumbnails are pulled up from the child albums if the parent doesn't have any photos itself, and the parent album does not display the large "no photos" image and message, but a more subtle one with child albums more visible.
Autore
Proprietario

This will be in the 2.1.0-beta.4 release

This will be in the 2.1.0-beta.4 release
Autore
Proprietario
Migrated from https://github.com/andysh-uk/blue-twilight/issues/54
aheathershaw chiuso questo probleam 2018-07-28 09:54:55 +01:00
Effettua l'accesso per partecipare alla conversazione.
Nessuna etichetta
bug
enhancement
feature
invalid
task
wip
Nessuna milestone
Nessuna assegnatario
1 Partecipanti
Notifiche
Data di scadenza
La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Riferimento: aheathershaw/blue-twilight#54
No description provided.