Update metadata should not remove photos it can't read #73

Новая задача

aheathershaw · 2018-07-28T23:39:37+01:00

aheathershaw прокомментировал(а)

2018-07-28 23:39:37 +01:00

Владелец

I tried to update meta-data for some albums and in some occasions it failed, and removed the uploaded photos.
This is an issue, since most probably a retry would succeed, but in any case uploaded photos should not be removed.

This is the full failed response:

The following items could not be analysed and were removed:
DSC_2070: mkdir(): File exists
DSC_2069: mkdir(): File exists
DSC_2067: mkdir(): File exists
DSC_2079: fopen(/storage/app/analysis-queue/09vm0p0y0x/5kwdj10y9nitxoi50cyk.jpeg): failed to open stream: No such file or directory

In this case the process should skip these files and give the chance of a retry, or at lease ask for permission to delete those files.

[LNT00](https://github.com/LNT00): I tried to update meta-data for some albums and in some occasions it failed, and removed the uploaded photos. This is an issue, since most probably a retry would succeed, but in any case uploaded photos should not be removed. This is the full failed response: The following items could not be analysed and were removed: DSC_2070: mkdir(): File exists DSC_2069: mkdir(): File exists DSC_2067: mkdir(): File exists DSC_2079: fopen(/storage/app/analysis-queue/09vm0p0y0x/5kwdj10y9nitxoi50cyk.jpeg): failed to open stream: No such file or directory In this case the process should skip these files and give the chance of a retry, or at lease ask for permission to delete those files.

aheathershaw добавил(а) к этапу Version 2.1.1

2018-07-28 23:39:37 +01:00

aheathershaw назначил(а) на себя 2018-07-28 23:39:37 +01:00

aheathershaw добавил(а) метку

bug

2018-07-28 23:39:37 +01:00

aheathershaw прокомментировал(а)

2018-07-28 23:40:13 +01:00

Автор

Владелец

Did it actually remove the record from the photos table or the physical file from the storage location? Ignore the path it’s given you in the error message - that’s a temporary storage path while it’s re-analysing. Check the place where the image files are physically stored (I.e. defined in your storage location.)

It definitely should not delete the originals! See your other ticket about upload/analyse failure - the fix in that should correct the reason why the metadata re-analyse failed.

Did it actually remove the record from the `photos` table or the physical file from the storage location? Ignore the path it’s given you in the error message - that’s a temporary storage path while it’s re-analysing. Check the place where the image files are physically stored (I.e. defined in your storage location.) It definitely should not delete the originals! See your other ticket about upload/analyse failure - the fix in that should correct the reason why the metadata re-analyse failed.

aheathershaw прокомментировал(а)

2018-07-28 23:40:21 +01:00

Автор

Владелец

I think the message still says it removed them because it’s the same screen used when analysing a new upload which does remove an uploaded file if the first analysis fails, but I don’t think it actually will have removed anything.

aheathershaw прокомментировал(а)

2018-07-28 23:40:51 +01:00

Автор

Владелец

LNT00:

The uploaded files were removed from storage, i searched for file names, not the analysis-queue location.

I will look further into this. maybe i can catch something to reproduce it with.

[LNT00](https://github.com/LNT00): The uploaded files were removed from storage, i searched for file names, not the analysis-queue location. I will look further into this. maybe i can catch something to reproduce it with.

aheathershaw прокомментировал(а)

2018-07-28 23:41:15 +01:00

Автор

Владелец

LNT00:

No, actually the files are not removed from storage (local storage). Maybe replace the message with something friendlier?
Also, although it fails for a certain file, metadata update is displayed as up-to-date for the album. A bit inconsistent.

On the other side, is there a bulk update option? It would be useful for large number of albums like in my case.

[LNT00](https://github.com/LNT00): No, actually the files are not removed from storage (local storage). Maybe replace the message with something friendlier? Also, although it fails for a certain file, metadata update is displayed as up-to-date for the album. A bit inconsistent. On the other side, is there a bulk update option? It would be useful for large number of albums like in my case.

aheathershaw прокомментировал(а)

2018-07-28 23:42:03 +01:00

Автор

Владелец

The message has been updated in 2.1.1 to remove the wording saying it will remove the photo.

Issue #81 raised for bulk updating metadata.

The message has been updated in 2.1.1 to remove the wording saying it will remove the photo. Issue #81 raised for bulk updating metadata.

aheathershaw прокомментировал(а)

2018-07-28 23:42:17 +01:00

Автор

Владелец

Migrated from https://github.com/andysh-uk/blue-twilight/issues/73