Update metadata should not remove photos it can't read #73

Kapalı
aheathershaw tarafından 2018-07-28 23:39:37 +01:00 açıldı · 6 yorum
Sahibi

LNT00:

I tried to update meta-data for some albums and in some occasions it failed, and removed the uploaded photos.
This is an issue, since most probably a retry would succeed, but in any case uploaded photos should not be removed.

This is the full failed response:

The following items could not be analysed and were removed:
DSC_2070: mkdir(): File exists
DSC_2069: mkdir(): File exists
DSC_2067: mkdir(): File exists
DSC_2079: fopen(/storage/app/analysis-queue/09vm0p0y0x/5kwdj10y9nitxoi50cyk.jpeg): failed to open stream: No such file or directory

In this case the process should skip these files and give the chance of a retry, or at lease ask for permission to delete those files.

[LNT00](https://github.com/LNT00): I tried to update meta-data for some albums and in some occasions it failed, and removed the uploaded photos. This is an issue, since most probably a retry would succeed, but in any case uploaded photos should not be removed. This is the full failed response: The following items could not be analysed and were removed: DSC_2070: mkdir(): File exists DSC_2069: mkdir(): File exists DSC_2067: mkdir(): File exists DSC_2079: fopen(/storage/app/analysis-queue/09vm0p0y0x/5kwdj10y9nitxoi50cyk.jpeg): failed to open stream: No such file or directory In this case the process should skip these files and give the chance of a retry, or at lease ask for permission to delete those files.
aheathershaw 2018-07-28 23:39:37 +01:00 Version 2.1.1 kilometre taşına ekledi
aheathershaw 2018-07-28 23:39:37 +01:00 kendini atadı
aheathershaw
bug
etiketini 2018-07-28 23:39:37 +01:00 ekledi
Yazar
Sahibi

Did it actually remove the record from the photos table or the physical file from the storage location? Ignore the path it’s given you in the error message - that’s a temporary storage path while it’s re-analysing. Check the place where the image files are physically stored (I.e. defined in your storage location.)

It definitely should not delete the originals! See your other ticket about upload/analyse failure - the fix in that should correct the reason why the metadata re-analyse failed.

Did it actually remove the record from the `photos` table or the physical file from the storage location? Ignore the path it’s given you in the error message - that’s a temporary storage path while it’s re-analysing. Check the place where the image files are physically stored (I.e. defined in your storage location.) It definitely should not delete the originals! See your other ticket about upload/analyse failure - the fix in that should correct the reason why the metadata re-analyse failed.
Yazar
Sahibi

I think the message still says it removed them because it’s the same screen used when analysing a new upload which does remove an uploaded file if the first analysis fails, but I don’t think it actually will have removed anything.

I think the message still says it removed them because it’s the same screen used when analysing a new upload which does remove an uploaded file if the first analysis fails, but I don’t think it actually will have removed anything.
Yazar
Sahibi

LNT00:

The uploaded files were removed from storage, i searched for file names, not the analysis-queue location.

I will look further into this. maybe i can catch something to reproduce it with.

[LNT00](https://github.com/LNT00): The uploaded files were removed from storage, i searched for file names, not the analysis-queue location. I will look further into this. maybe i can catch something to reproduce it with.
Yazar
Sahibi

LNT00:

No, actually the files are not removed from storage (local storage). Maybe replace the message with something friendlier?
Also, although it fails for a certain file, metadata update is displayed as up-to-date for the album. A bit inconsistent.

On the other side, is there a bulk update option? It would be useful for large number of albums like in my case.

[LNT00](https://github.com/LNT00): No, actually the files are not removed from storage (local storage). Maybe replace the message with something friendlier? Also, although it fails for a certain file, metadata update is displayed as up-to-date for the album. A bit inconsistent. On the other side, is there a bulk update option? It would be useful for large number of albums like in my case.
Yazar
Sahibi

The message has been updated in 2.1.1 to remove the wording saying it will remove the photo.

Issue #81 raised for bulk updating metadata.

The message has been updated in 2.1.1 to remove the wording saying it will remove the photo. Issue #81 raised for bulk updating metadata.
Yazar
Sahibi
Migrated from https://github.com/andysh-uk/blue-twilight/issues/73
Bu konuşmaya katılmak için oturum aç.
Kilometre Taşı Yok
Atanan Kişi Yok
1 Katılımcı
Bildirimler
Bitiş Tarihi
Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: aheathershaw/blue-twilight#73
Herhangi bir açıklama sağlanmadı.