Upload/analize fails without any reason #74

New Issue

aheathershaw · 2018-07-28T23:43:10+01:00

aheathershaw commented

2018-07-28 23:43:10 +01:00

Is there a log file for failed uploads/analysis? I get random failures for no reason, on retry the files are uploaded and analyzed correctly.

[LNT00](https://github.com/LNT00): Is there a log file for failed uploads/analysis? I get random failures for no reason, on retry the files are uploaded and analyzed correctly.

aheathershaw added this to the Version 2.1.1 milestone 2018-07-28 23:43:10 +01:00

aheathershaw self-assigned this 2018-07-28 23:43:10 +01:00

aheathershaw added the

bug

label 2018-07-28 23:43:10 +01:00

aheathershaw commented

2018-07-28 23:43:25 +01:00

I think this is related to the issue seen in your log files saying “mkdir: file exists”. Before the app calls mkdir it checks if the folder already exists and doesn’t try and create it if it does.

The fact mkdir is failing even though it shouldn’t be executed suggests a possible race condition with multiple uploads, explaining why it works if you try again later.

On my systems only errors are thrown however it looks like warnings are being thrown on your hosting causing the script to fail.

Can you please amend the app\Helpers\FileHelper.php file and replace “mkdir” with “@mkdir” which should suppress the warning and see if you still get failures?

I think this is related to the issue seen in your log files saying “mkdir: file exists”. Before the app calls mkdir it checks if the folder already exists and doesn’t try and create it if it does. The fact mkdir is failing even though it shouldn’t be executed suggests a possible race condition with multiple uploads, explaining why it works if you try again later. On my systems only errors are thrown however it looks like warnings are being thrown on your hosting causing the script to fail. Can you please amend the `app\Helpers\FileHelper.php` file and replace “mkdir” with “@mkdir” which should suppress the warning and see if you still get failures?

aheathershaw commented

2018-07-28 23:44:14 +01:00

LNT00:

No, it's not related to that issue. I uploaded multiple files and some failed, without any warning. I will post here the next error i get. When i retried only the failed photos, it worked correctly.
I couldn't find a specific case, I've uploaded file counts from 2 to 3600+ at one time, and nothing similar happened to get an idea why sometimes fail occurs.

[LNT00](https://github.com/LNT00): No, it's not related to that issue. I uploaded multiple files and some failed, without any warning. I will post here the next error i get. When i retried only the failed photos, it worked correctly. I couldn't find a specific case, I've uploaded file counts from 2 to 3600+ at one time, and nothing similar happened to get an idea why sometimes fail occurs.

aheathershaw commented

2018-07-28 23:44:27 +01:00

Please try my suggested fix - this would cause random failures that seem to work fine the next time.

If there was an issue with a specific photo it would fail consistently.

I’ve uploaded 1,000 photos at a time myself and never had an issue because I have PHP warnings turned off.

Please try my suggested fix - this would cause random failures that seem to work fine the next time. If there was an issue with a specific photo it would fail consistently. I’ve uploaded 1,000 photos at a time myself and never had an issue because I have PHP warnings turned off.

aheathershaw commented

2018-07-28 23:44:52 +01:00

LNT00:

Sure, i already did that.

[LNT00](https://github.com/LNT00): Sure, i already did that.

aheathershaw commented

2018-07-28 23:45:02 +01:00

I've added my suggested workaround to the 2.1.1 release. Please can you try this release once it's published (in the next couple of days) and see if you're still having the issue?